[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] tests: add file-write-read test
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] tests: add file-write-read test |
Date: |
Tue, 24 Nov 2015 13:46:56 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/24/2015 11:04 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> This test exhibits a POSIX behaviour regarding switching between write
> and read. It's undefined result if the application doesn't ensure a
> flush between the two operations (with glibc, the flush can be implicit
> when the buffer size is relatively small). The previous commit fixes
> this test.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1210246
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/test-qga.c | 95
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 93 insertions(+), 2 deletions(-)
> +
> + /* seek to 0 */
> + cmd = g_strdup_printf("{'execute': 'guest-file-seek',"
> + " 'arguments': { 'handle': %" PRId64 ", "
> + " 'offset': %d, 'whence': %d } }",
> + id, 0, SEEK_SET);
If my patch goes in first, you'll want this to be s/SEEK_SET/0/ to
match. (If yours goes in first, I'll spin a v2 of my patch to cover all
sites in the testsuite that need munging).
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05454.html
With that figured out,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature