[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-e
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive |
Date: |
Fri, 27 Nov 2015 20:08:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 23.11.2015 16:59, Kevin Wolf wrote:
> Creating an empty drive while specifying 'format' doesn't make sense.
> The specified format driver would simply be ignored.
>
> Make a set 'format' option an indication that a non-empty drive should
> be created. This makes 'format' consistent with 'driver' and allows
> using it with a block driver that doesn't need any other options (like
> null-co/null-aio).
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 5 +----
> tests/qemu-iotests/iotests.py | 2 +-
> 2 files changed, 2 insertions(+), 5 deletions(-)
Besides the failing make check, the patch looks good.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options(), (continued)
- [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options(), Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 07/21] block: Pass driver-specific options to .bdrv_refresh_filename(), Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 08/21] block: Keep "driver" in bs->options, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 10/21] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 12/21] block: Split out parse_json_protocol(), Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 09/21] block: Allow specifying child options in reopen, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 13/21] block: Introduce bs->explicit_options, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 15/21] qemu-iotests: Remove cache mode test without medium, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 16/21] block: reopen: Extract QemuOpts for generic block layer options, Kevin Wolf, 2015/11/23