[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMP
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED |
Date: |
Mon, 30 Nov 2015 19:32:16 +0800 |
One new QMP event DUMP_COMPLETED is added. It is used when user
specified "detach" in dump, and triggered when the dump finishes
(either succeeded or failed). If failed, one "err" data will be
passed with specific error message.
Signed-off-by: Peter Xu <address@hidden>
---
docs/qmp-events.txt | 14 ++++++++++++++
dump.c | 6 +++++-
qapi/event.json | 10 ++++++++++
3 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt
index d2f1ce4..7b9f835 100644
--- a/docs/qmp-events.txt
+++ b/docs/qmp-events.txt
@@ -674,3 +674,17 @@ Note: If action is "reset", "shutdown", or "pause" the
WATCHDOG event is
followed respectively by the RESET, SHUTDOWN, or STOP events.
Note: this event is rate-limited.
+
+DUMP_COMPLETED
+--------------
+
+Emitted when the guest has finished one memory dump.
+
+Data:
+
+- "error": Error message when dump failed (json-string, optional)
+
+Example:
+
+{ "event": "DUMP_COMPLETED",
+ "data": {} }
diff --git a/dump.c b/dump.c
index 14fd41f..43f565d 100644
--- a/dump.c
+++ b/dump.c
@@ -25,6 +25,7 @@
#include "qapi/error.h"
#include "qapi/qmp/qerror.h"
#include "qmp-commands.h"
+#include "qapi-event.h"
#include <zlib.h>
#ifdef CONFIG_LZO
@@ -1633,8 +1634,11 @@ static void *dump_thread(void *data)
dump_process(s, &err);
if (err) {
- /* TODO: notify user the error */
+ qapi_event_send_dump_completed(true, error_get_pretty(err),
+ &error_abort);
error_free(err);
+ } else {
+ qapi_event_send_dump_completed(false, NULL, &error_abort);
}
return NULL;
}
diff --git a/qapi/event.json b/qapi/event.json
index f0cef01..c46214b 100644
--- a/qapi/event.json
+++ b/qapi/event.json
@@ -356,3 +356,13 @@
##
{ 'event': 'MEM_UNPLUG_ERROR',
'data': { 'device': 'str', 'msg': 'str' } }
+
+##
+# @DUMP_COMPLETED
+#
+# Emitted when background dump has completed
+#
+# Since: 2.6
+##
+{ 'event': 'DUMP_COMPLETED' ,
+ 'data': { '*error': 'str' } }
--
2.4.3
- Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus, (continued)
- [Qemu-devel] [PATCH v3 04/12] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 06/12] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 07/12] dump-guest-memory: add "detach" support, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED,
Peter Xu <=
- [Qemu-devel] [PATCH v3 09/12] DumpState: adding total_size and written_size fields, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump", Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 11/12] Dump: add hmp command "info dump", Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 12/12] Dump: enhance the documentations., Peter Xu, 2015/11/30