|
From: | Xiao Guangrong |
Subject: | Re: [Qemu-devel] [PATCH v8 4/5] nvdimm acpi: build ACPI nvdimm devices |
Date: | Mon, 30 Nov 2015 20:31:16 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/30/2015 06:32 PM, Michael S. Tsirkin wrote:
On Mon, Nov 16, 2015 at 06:51:02PM +0800, Xiao Guangrong wrote:NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM DevicesForgot to mention: Pls put spec info in code comments near relevant functions, not just the log.
Sure, good to me.
+ +static void nvdimm_build_ssdt(GSList *device_list, GArray *table_offsets, + GArray *table_data, GArray *linker) +{ + Aml *ssdt, *sb_scope, *dev, *method;So why don't we skip this completely if device list is empty?
Yes, it is exactly what we did: void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data, GArray *linker) { GSList *device_list; /* no NVDIMM device is plugged. */ device_list = nvdimm_get_plugged_device_list(); if (!device_list) { return; } nvdimm_build_nfit(device_list, table_offsets, table_data, linker); + nvdimm_build_ssdt(device_list, table_offsets, table_data, linker); g_slist_free(device_list); }
[Prev in Thread] | Current Thread | [Next in Thread] |