[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coverity: Model g_poll()
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] coverity: Model g_poll() |
|
Date: |
Tue, 1 Dec 2015 14:13:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 01/12/2015 14:03, Markus Armbruster wrote:
> Coverity now reports two more CHECKED_RETURN:
>
> * qemu-char.c:1248: Should be fixed by Paolo's "qemu-char: retry
> g_poll on EINTR".
>
> * migration/qemu-file-unix.c:75: if g_poll() fails, we retry sending
> before the file descriptor is ready. Errors other than EINTR are
> mostly theoretical, though.
EINTR is harmless too here, you'll just get another EAGAIN. I'll mark
it as Intentional / Fix Required in the coverity dashboard.
Paolo
> Signed-off-by: Markus Armbruster <address@hidden>
> ---