qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for lay


From: Richard Henderson
Subject: Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area
Date: Tue, 1 Dec 2015 09:20:41 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/01/2015 09:15 AM, Eduardo Habkost wrote:
On Tue, Dec 01, 2015 at 09:09:47AM -0800, Richard Henderson wrote:
On 11/30/2015 03:18 AM, Paolo Bonzini wrote:
Because this is always little endian, I would write it as uint8_t[16][16].

Maybe.  That isn't altogether handy for TCG, since we'll be wanting to bswap
these buffers (probably in uint64_t chunks).

X86XSaveArea will be used only when loading/saving state using
xsave, not for executing regular instructions.

... like the regular instruction xsave?

https://patchwork.ozlabs.org/patch/493318/

In X86CPU, the
data is already stored as XMMReg unions (the one with the
XMM_[BWDQ] helpers).

Of course. But those unions are arranged to be in big-endian format on big-endian hosts. So we need to swap the data back to little-endian format for storage into guest memory.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]