[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when i
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state |
Date: |
Wed, 2 Dec 2015 08:50:48 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, 12/01 21:28, Peter Xu wrote:
> Signed-off-by: Peter Xu <address@hidden>
> ---
> dump.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/dump.c b/dump.c
> index e46749d..65d1f7e 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -1626,13 +1626,17 @@ void qmp_dump_guest_memory(bool paging, const char
> *file,
> DumpState *s;
> Error *local_err = NULL;
>
> + if (runstate_check(RUN_STATE_INMIGRATE)) {
> + error_setg(errp, "Dump not allowed during incoming migration.");
> + return;
> + }
> +
> /* if there is a dump in background, we should wait until the dump
> * finished */
> if (dump_in_progress()) {
> error_setg(errp, "There is a dump in process, please wait.");
> return;
> }
> -
Blank line change, please drop.
Fam
> /*
> * kdump-compressed format need the whole memory dumped, so paging or
> * filter is not supported here.
> --
> 2.4.3
>
- Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}()., (continued)
- [Qemu-devel] [PATCH v4 02/11] dump-guest-memory: add "detach" flag for QMP/HMP interfaces., Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 03/11] dump-guest-memory: using static DumpState, add DumpStatus, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 04/11] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 05/11] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/12/01
- Re: [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state,
Fam Zheng <=
- [Qemu-devel] [PATCH v4 07/11] dump-guest-memory: add "detach" support, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/01
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Fam Zheng, 2015/12/01
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Eric Blake, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Eric Blake, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/02