Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 10/12/2015 11:19, Markus Armbruster wrote:
>> +    object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr",
>> + &error_fatal);object_property_set_int(OBJECT(cpu),
>> + MPCORE_PERIPHBASE,
>> + "reset-cbar",
>> + &error_fatal);object_property_set_bool(OBJECT(cpu),
>> + true,
>> + "realized",
>> + &error_fatal);
>
> Something went wrong here. :)

Once again I demonstrate incompetence at proofreading my own patches %-}

No idea what happened.  I'll fix it.

>>  void qdev_prop_set_drive_nofail(DeviceState *dev, const char *name,
>>                                  BlockBackend *value)
>>  {
>> -    Error *err = NULL;
>> -
>> -    qdev_prop_set_drive(dev, name, value, &err);
>> -    if (err) {
>> -        error_report_err(err);
>> -        exit(1);
>> -    }
>> +    qdev_prop_set_drive(dev, name, value, &error_fatal);
>>  }
>
>
> This should be inlined entirely into the callers (possibly as a follow up).

Yes, a FOO_nofail() wrapper around a FOO() taking Error ** is pointless.
I'll prep a follow-up patch.

> Otherwise looks great, thanks!

Thanks!