[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/11] pseries: Clean up error handling in xics_
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 09/11] pseries: Clean up error handling in xics_system_init() |
Date: |
Fri, 11 Dec 2015 11:08:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/12/15 01:11, David Gibson wrote:
> Use the error handling infrastructure to pass an error out from
> try_create_xics() instead of assuming &error_abort - the caller is in a
> better position to decide on error handling policy.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/spapr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 546d2f5..c376748 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -111,7 +111,7 @@ static XICSState *try_create_xics(const char *type, int
> nr_servers,
> }
>
> static XICSState *xics_system_init(MachineState *machine,
> - int nr_servers, int nr_irqs)
> + int nr_servers, int nr_irqs, Error **errp)
> {
> XICSState *icp = NULL;
>
> @@ -129,7 +129,7 @@ static XICSState *xics_system_init(MachineState *machine,
> }
>
> if (!icp) {
> - icp = try_create_xics(TYPE_XICS, nr_servers, nr_irqs, &error_abort);
> + icp = try_create_xics(TYPE_XICS, nr_servers, nr_irqs, errp);
> }
>
> return icp;
> @@ -1808,7 +1808,7 @@ static void ppc_spapr_init(MachineState *machine)
> spapr->icp = xics_system_init(machine,
> DIV_ROUND_UP(max_cpus *
> kvmppc_smt_threads(),
> smp_threads),
> - XICS_IRQS);
> + XICS_IRQS, &error_fatal);
>
> if (smc->dr_lmb_enabled) {
> spapr_validate_node_memory(machine, &error_fatal);
>
Could you maybe explain in the patch description why you changed the
behavior in case of errors from "error_abort" into "error_fatal" ?
Thomas
- Re: [Qemu-devel] [PATCH 02/11] pseries: Cleanup error handling of spapr_cpu_init(), (continued)
- [Qemu-devel] [PATCH 11/11] pseries: Clean up error reporting in htab migration functions, David Gibson, 2015/12/10
- [Qemu-devel] [PATCH 08/11] pseries: Clean up error handling in spapr_rtas_register(), David Gibson, 2015/12/10
- [Qemu-devel] [PATCH 09/11] pseries: Clean up error handling in xics_system_init(), David Gibson, 2015/12/10
- Re: [Qemu-devel] [PATCH 09/11] pseries: Clean up error handling in xics_system_init(),
Thomas Huth <=
- [Qemu-devel] [PATCH 10/11] pseries: Clean up error handling in ppc_spapr_init(), David Gibson, 2015/12/10
- [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling, David Gibson, 2015/12/10
- [Qemu-devel] [PATCH 07/11] pseries: Cleanup error handling in spapr_kvm_type(), David Gibson, 2015/12/10