[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging to tracepoints |
Date: |
Tue, 15 Dec 2015 07:59:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/12/15 11:39, Paolo Bonzini wrote:
> "Unimplemented" messages go to stderr, everything else goes to tracepoints
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
[...]
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 9d62e02..919aa83 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
[...]
> @@ -3972,14 +3974,15 @@ give_sigsegv:
>
> long do_sigreturn(CPUOpenRISCState *env)
> {
> -
> - qemu_log("do_sigreturn: not implemented\n");
> + trace_user_do_sigreturn(env, 0);
> + fprintf(stderr, "do_sigreturn: not implemented\n");
> return -TARGET_ENOSYS;
> }
>
> long do_rt_sigreturn(CPUOpenRISCState *env)
> {
> - qemu_log("do_rt_sigreturn: not implemented\n");
> + trace_user_do_rt_sigreturn(env, 0);
> + fprintf(stderr, "do_rt_sigreturn: not implemented\n");
> return -TARGET_ENOSYS;
> }
Why not simply using qemu_log_mask(LOG_UNIMP, ...) instead? Isn't that
what the LOG_UNIMP flag is good for?
Thomas
- Re: [Qemu-devel] [PATCH 06/11] ppc: cleanup logging, (continued)
- [Qemu-devel] [PATCH 07/11] tricore: avoid "naked" qemu_log, Paolo Bonzini, 2015/12/12
- [Qemu-devel] [PATCH 09/11] user: introduce "-d page", Paolo Bonzini, 2015/12/12
- [Qemu-devel] [PATCH 10/11] linux-user: avoid "naked" qemu_log, Paolo Bonzini, 2015/12/12
- [Qemu-devel] [PATCH 08/11] xtensa: avoid "naked" qemu_log, Paolo Bonzini, 2015/12/12
- [Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging to tracepoints, Paolo Bonzini, 2015/12/12