qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 01/14] q35: Remove MCHPCIState.guest_info fie


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH v2 01/14] q35: Remove MCHPCIState.guest_info field
Date: Tue, 15 Dec 2015 13:10:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
The field is not used for anything.

Signed-off-by: Eduardo Habkost <address@hidden>
---
  hw/i386/pc_q35.c          | 1 -
  include/hw/pci-host/q35.h | 1 -
  2 files changed, 2 deletions(-)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 9da751b..43ee8bb 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -176,7 +176,6 @@ static void pc_q35_init(MachineState *machine)
      q35_host->mch.address_space_io = get_system_io();
      q35_host->mch.below_4g_mem_size = pcms->below_4g_mem_size;
      q35_host->mch.above_4g_mem_size = pcms->above_4g_mem_size;
-    q35_host->mch.guest_info = guest_info;
      /* pci */
      qdev_init_nofail(DEVICE(q35_host));
      phb = PCI_HOST_BRIDGE(q35_host);
diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
index dbe6dc0..c5c073d 100644
--- a/include/hw/pci-host/q35.h
+++ b/include/hw/pci-host/q35.h
@@ -59,7 +59,6 @@ typedef struct MCHPCIState {
      ram_addr_t below_4g_mem_size;
      ram_addr_t above_4g_mem_size;
      uint64_t pci_hole64_size;
-    PcGuestInfo *guest_info;
      uint32_t short_root_bus;
      IntelIOMMUState *iommu;
  } MCHPCIState;


So nobody is using it.


Reviewed-by: Marcel Apfelbaum <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]