[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused s
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state |
Date: |
Wed, 16 Dec 2015 10:12:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 16/12/2015 10:00, Denis V. Lunev wrote:
> With pvpanic or HyperV panic devices could be moved into the paused state
> with ' <on_crash>preserve</on_crash>'. In this state VM reacts only to
> 'virsh destroy' or 'continue'.
>
> 'virsh reset' command is usually used to force guest reset. The expectation
> of the behavior of this command is that the guest will be force restarted.
> This is not true at the moment.
Does "virsh reset" + "virsh continue" work, and if not why?
> Thus it is quite natural to process 'virh reset' aka qmp_system_reset
> this way, i.e. allow to reset the guest. This behavior is similar to
> one observed with 'reset' button on real hardware :)
Paolo
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Dmitry Andreev <address@hidden>
> ---
> qmp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/qmp.c b/qmp.c
> index 0a1fa19..df17a33 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -112,6 +112,10 @@ void qmp_stop(Error **errp)
> void qmp_system_reset(Error **errp)
> {
> qemu_system_reset_request();
> +
> + if (!runstate_is_running()) {
> + vm_start();
> + }
> }
>
> void qmp_system_powerdown(Error **erp)
>