[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME |
Date: |
Thu, 17 Dec 2015 17:35:21 +0100 |
Cc: Stefano Stabellini <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
---
xen-hvm.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms,
void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr)
{
+ /* FIXME caller ram_block_add() wants error_setg() on failure */
unsigned long nr_pfn;
xen_pfn_t *pfn_list;
int i;
@@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void
*data)
int xen_hvm_init(PCMachineState *pcms,
MemoryRegion **ram_memory)
{
+ /*
+ * FIXME Returns -1 without cleaning up on some errors (harmless
+ * as long as the caller exit()s on error), dies with hw_error()
+ * on others. hw_error() isn't approprate here. Should probably
+ * simply exit() on all errors.
+ */
int i, rc;
xen_pfn_t ioreq_pfn;
xen_pfn_t bufioreq_pfn;
--
2.4.3
- [Qemu-devel] [PATCH v3 10/13] isa: Clean up error handling around isa_bus_new(), (continued)
- [Qemu-devel] [PATCH v3 10/13] isa: Clean up error handling around isa_bus_new(), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 04/13] etraxfs_eth: Don't use hw_error() in init() method, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 06/13] error: Don't append a newline when printing the error hint, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 03/13] arm_mptimer: Don't use hw_error() in realize() method, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 12/13] audio: Clean up inappropriate and unreachable use of hw_error(), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 02/13] omap: Don't use hw_error() in device init() methods, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 07/13] hw/arm/virt: Fix property "gic-version" error handling, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 01/13] hw: Don't use hw_error() for machine initialization errors, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME,
Markus Armbruster <=