[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions |
Date: |
Thu, 17 Dec 2015 19:28:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Jason J. Herne" <address@hidden> writes:
> On 12/14/2015 10:40 AM, Markus Armbruster wrote:
>> "Jason J. Herne" <address@hidden> writes:
>>
>>> On 12/14/2015 07:47 AM, Markus Armbruster wrote:
>>>> "Jason J. Herne" <address@hidden> writes:
>>>>
>>>>> We don't want newlines embedded in error messages. This seems to
>>>>> be a common
>>>>> problem with new code so let's try to catch it with checkpatch.
>>>>>
>>>>> This will not catch cases where newlines are inserted into the middle of
>>>>> an
>>>>> existing multi-line statement. But those cases should be rare.
>>>>>
>>>>> Signed-off-by: Jason J. Herne <address@hidden>
>>>>
> ...
>>> But I will take a look at this series and see if we can do better :).
>>
>> Thanks! If we can't, then I'm for taking this imperfect patch, because
>> flagging some of these mistakes is better than flagging none.
>>
>>
>
> I won't get a chance to get back to this before the new year. So feel
> free to push this (unless someone objects) and I'll see what I can do
> about improving it in January.
Makes sense. Applied to my local error-next branch.
> Happy holidays! :)
Thanks, same to you!