[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails
From: |
Samuel Thibault |
Subject: |
[Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails |
Date: |
Sat, 19 Dec 2015 22:24:55 +0100 |
From: Guillaume Subiron <address@hidden>
Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent, recording the packet for icmp errors, which does not
makes sense since the packet was not actually sent, errors would be
related to a previous packet.
This patch adds a goto bad to cut the execution of this function.
Signed-off-by: Guillaume Subiron <address@hidden>
Signed-off-by: Samuel Thibault <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
---
slirp/udp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/slirp/udp.c b/slirp/udp.c
index fee13b4..ce63414 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
*ip=save_ip;
DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
+ goto bad;
}
m_free(so->so_m); /* used for ICMP if error on sorecvfrom */
--
2.6.2
- [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode, Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails,
Samuel Thibault <=
- [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic, Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 5/9] slirp: Factorizing address translation, Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 9/9] slirp: Adding family argument to tcp_fconnect(), Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 8/9] slirp: Make udp_attach IPv6 compatible, Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 6/9] slirp: Factorizing and cleaning solookup(), Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 2/9] slirp: Generalizing and neutralizing ARP code, Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for produced frames, Samuel Thibault, 2015/12/19
- [Qemu-devel] [PATCH 4/9] slirp: Make Socket structure IPv6 compatible, Samuel Thibault, 2015/12/19
- Re: [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode, Eric Blake, 2015/12/21