qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] sdhci: add optional quirk property to di


From: Andrew Baumann
Subject: Re: [Qemu-devel] [PATCH v2 3/3] sdhci: add optional quirk property to disable card insertion/removal interrupts
Date: Mon, 21 Dec 2015 21:53:48 +0000

> From: Peter Crosthwaite [mailto:address@hidden
> Sent: Monday, 21 December 2015 13:42
> On Mon, Dec 21, 2015 at 1:31 PM, Andrew Baumann
> <address@hidden> wrote:
> > This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC
> > controller, where the card insert bit is documented as unimplemented
> > (always reads zero, doesn't generate interrupts) but is in fact
> > observed on hardware as set at power on, but is cleared (and remains
> > clear) on subsequent controller resets.
> > @@ -1208,6 +1210,7 @@ const VMStateDescription sdhci_vmstate = {
> >          VMSTATE_UINT16(data_count, SDHCIState),
> >          VMSTATE_UINT64(admasysaddr, SDHCIState),
> >          VMSTATE_UINT8(stopped_state, SDHCIState),
> > +        VMSTATE_BOOL(noeject_quirk, SDHCIState),
> 
> Sorry, one small thing I missed, static props should not be in the
> VMSD. I think you just need to drop the VMSTATE_ addition here.
> Otherwise you would need a VMSD version bump.

Yes we can drop the VMSTATE addition here.

> Is the patch missing the corresponding header change to add the new field?

Aargh. You're right, sorry, my mistake -- I've been breaking up all the changes 
into different branches to get them submitted, and missed the header file here. 
Will resend.

Andrew

reply via email to

[Prev in Thread] Current Thread [Next in Thread]