Re: [Qemu-devel] [PATCH 09/10] qcow2: Make image inaccessible after failed qcow2_invalidate_cache()

[Eric Blake]

On 12/22/2015 09:46 AM, Kevin Wolf wrote:
> If qcow2_invalidate_cache() fails, we are in a state where qcow2_close()
> has already been completed, but the image hasn't been reopened yet.
> Calling into any qcow2 function for an image in this state will cause
> crashes.
> 
> The real solution would be to get rid of the close/open pair and instead
> do an atomic reset of the involved data structures, but this isn't
> trivial, so let's just make the image inaccessible for now.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2.c | 3 +++
>  1 file changed, 3 insertions(+)

Band-aids are better than nothing.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature