[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror |
Date: |
Thu, 24 Dec 2015 01:26:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 23.12.2015 06:59, Fam Zheng wrote:
> v3: Rebase to master.
Why did you drop patch 1?
Max
> v2: 01: Move bdrv_op_block_all down. [Max]
> 02, 04: Add Max's rev-by.
> 03: Check has_mode and fix "return;". [Max]
> 05: Check target->blk.
> Drop superfluous whitespace. [Max]
> 06: Drop superfluous whitespace hunk and add Max's rev-by. [Max]
>
> This is the counterpart of blockdev-backup. The biggest value of this command
> is to allow full flexibility on target image open options, via blockdev-add.
> For example this could help solve the target provisioning issue in:
>
> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg02139.html
>
>
>
> Fam Zheng (5):
> block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE
> block: Extract blockdev part of qmp_drive_mirror
> block: Add check on mirror target
> qmp: Add blockdev-mirror command
> iotests: Add test cases for blockdev-mirror
>
> blockdev.c | 179
> ++++++++++++++++++++++++++++++----------
> hw/block/dataplane/virtio-blk.c | 2 +-
> include/block/block.h | 3 +-
> qapi/block-core.json | 47 +++++++++++
> qmp-commands.hx | 48 +++++++++++
> tests/qemu-iotests/041 | 100 ++++++++++++++++------
> tests/qemu-iotests/041.out | 4 +-
> 7 files changed, 314 insertions(+), 69 deletions(-)
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror, Fam Zheng, 2015/12/23
- [Qemu-devel] [PATCH v3 1/5] block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE, Fam Zheng, 2015/12/23
- [Qemu-devel] [PATCH v3 2/5] block: Extract blockdev part of qmp_drive_mirror, Fam Zheng, 2015/12/23
- [Qemu-devel] [PATCH v3 3/5] block: Add check on mirror target, Fam Zheng, 2015/12/23
- [Qemu-devel] [PATCH v3 4/5] qmp: Add blockdev-mirror command, Fam Zheng, 2015/12/23
- [Qemu-devel] [PATCH v3 5/5] iotests: Add test cases for blockdev-mirror, Fam Zheng, 2015/12/23
- Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror,
Max Reitz <=