[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] net/dump: fix nfds->filename leak
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] net/dump: fix nfds->filename leak |
Date: |
Thu, 24 Dec 2015 11:25:22 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 12/23/2015 03:43 PM, Li Zhijian wrote:
> Cc: Jason Wang <address@hidden>
> Signed-off-by: Li Zhijian <address@hidden>
> ---
> net/dump.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/net/dump.c b/net/dump.c
> index ce16a4b..347b5ca 100644
> --- a/net/dump.c
> +++ b/net/dump.c
> @@ -329,6 +329,13 @@ static void filter_dump_instance_init(Object *obj)
> file_dump_set_filename, NULL);
> }
>
> +static void filter_dump_instance_finalize(Object *obj)
> +{
> + NetFilterDumpState *nfds = FILTER_DUMP(obj);
> +
> + g_free(nfds->filename);
> +}
> +
> static void filter_dump_class_init(ObjectClass *oc, void *data)
> {
> NetFilterClass *nfc = NETFILTER_CLASS(oc);
> @@ -343,6 +350,7 @@ static const TypeInfo filter_dump_info = {
> .parent = TYPE_NETFILTER,
> .class_init = filter_dump_class_init,
> .instance_init = filter_dump_instance_init,
> + .instance_finalize = filter_dump_instance_finalize,
> .instance_size = sizeof(NetFilterDumpState),
> };
>
Applied to my -net.
Thanks