Re: [Qemu-devel] [PATCH 0/7] target-ppc: endian fixes for KVM and gdbstub

[Greg Kurz]

On Fri, 18 Dec 2015 11:18:16 +0100
Greg Kurz <address@hidden> wrote:
> Hi,
> 
> This series is a sequel to Anton's tentative at bringing VSX support in
> our gdbstub:
> 
> http://patchwork.ozlabs.org/patch/453758/
> 
> Indeed, FP, SPE and Altivec registers need to be copied to memory with
> the appropriate ordering, like we already do for core registers. This
> series reuses the maybe_bswap_register() helper to do the job, since
> it already handles the user mode case where the target endianness is
> known at build time and don't need byteswap. This is covered by
> patches 2 to 6.
> 
> I also found more serious issues that probably break more than gdbstub.
> 
> First one is a bug in KVM, that completely breaks the KVM_GET_ONE_REG
> and KVM_SET_ONE_REG ioctls for Altivec registers. I've already sent a
> patch:
> 
> http://patchwork.ozlabs.org/patch/557568/
> 
> Second one is a bug in QEMU that breaks synchronisation with KVM for FP,
> Altivec and VSX registers on little-endian hosts. I pushed the fix to
> patch 1 since it is needed for the gdbstub fixes to actually work, but it
> could even be handled separately.
> 
> And finally, patch 7 is Anton's + the byteswapping for little-endian
> guests.
> Happy new year !
> Cheers.
> 

Ping ?

> ---
> 
> Anton Blanchard (1):
>       target-ppc: gdbstub: Add VSX support
> 
> Greg Kurz (6):
>       target-ppc: kvm: fix floating point registers sync on little-endian 
> hosts
>       target-ppc: rename and export maybe_bswap_register()
>       target-ppc: gdbstub: fix float registers for little-endian guests
>       target-ppc: gdbstub: introduce avr_need_swap()
>       target-ppc: gdbstub: fix altivec registers for little-endian guests
>       target-ppc: gdbstub: fix spe registers for little-endian guests
> 
> 
>  configure                   |    6 ++-
>  gdb-xml/power-vsx.xml       |   44 +++++++++++++++++++++++
>  target-ppc/cpu.h            |    1 +
>  target-ppc/gdbstub.c        |   10 +++--
>  target-ppc/kvm.c            |   12 ++++++
>  target-ppc/translate_init.c |   84 
> +++++++++++++++++++++++++++++++++++--------
>  6 files changed, 134 insertions(+), 23 deletions(-)
>  create mode 100644 gdb-xml/power-vsx.xml
> 
>