[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion
|
From: |
Mark Cave-Ayland |
|
Subject: |
Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices |
|
Date: |
Mon, 4 Jan 2016 19:15:47 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
On 04/01/16 19:04, P J P wrote:
> +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+
> | /* Calculate current offset */
> | - offset = (int64_t)(s->lba << 11) + s->io_buffer_index;
> | + offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index;
>
> Maybe ((int64_t)s->lba << 11) ? No parenthesis around s->lba.
Yes that works here too (perhaps I was just being over-cautious).
Alex/John, please let me know if you want me to resubmit.
ATB,
Mark.
Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices, John Snow, 2016/01/05