[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 06/11] igd: use defines for standard pci conf
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v3 06/11] igd: use defines for standard pci config space offsets |
Date: |
Wed, 6 Jan 2016 14:43:47 +0000 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Tue, 5 Jan 2016, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
> hw/pci-host/igd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c
> index 6f52ab1..0784128 100644
> --- a/hw/pci-host/igd.c
> +++ b/hw/pci-host/igd.c
> @@ -10,9 +10,9 @@ typedef struct {
>
> /* Here we just expose minimal host bridge offset subset. */
> static const IGDHostInfo igd_host_bridge_infos[] = {
> - {0x08, 2}, /* revision id */
> - {0x2c, 2}, /* sybsystem vendor id */
> - {0x2e, 2}, /* sybsystem id */
> + {PCI_REVISION_ID, 2},
> + {PCI_SUBSYSTEM_VENDOR_ID, 2},
> + {PCI_SUBSYSTEM_ID, 2},
> {0x50, 2}, /* SNB: processor graphics control register */
> {0x52, 2}, /* processor graphics control register */
> {0xa4, 4}, /* SNB: graphics base of stolen memory */
> --
> 1.8.3.1
>