[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga()
From: |
Cao jin |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga() |
Date: |
Thu, 7 Jan 2016 11:26:03 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 01/06/2016 11:53 PM, Eric Blake wrote:
On 01/05/2016 07:39 PM, Cao jin wrote:
[...]
Please no '!' in error messages. We aren't shouting at the user.
Interesting, I didn`t think of this kind of questions before. will fix
XEN_PT_ERR(d, "Setup VGA BIOS of passthrough GFX failed!\n");
Do we still need the XEN_PT_ERR() alongside setting the local error?
this is fixed in "4/4 convert to realize" patch, as I said in last mail,
I try to make every patch as small as possible
xen_host_pci_device_put(&s->real_device);
return -1;
This leaks local_err.
[...]
--
Yours Sincerely,
Cao jin
[Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize(), Cao jin, 2016/01/05
[Qemu-devel] [PATCH v3 1/4] Add Error **errp for xen_host_pci_device_get(), Cao jin, 2016/01/05