[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endia
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper |
Date: |
Fri, 8 Jan 2016 11:22:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 08/01/2016 11:07, Cornelia Huck wrote:
> On Fri, 8 Jan 2016 10:21:40 +0100
> Greg Kurz <address@hidden> wrote:
>
>> On Thu, 7 Jan 2016 21:07:26 +0100
>> Laurent Vivier <address@hidden> wrote:
>
>>> IMHO, I think 4/6 and 5/6 can be merged as there is no change in the
>>> behavior and they are only consolidating code.
>>>
>>
>> Maybe but I'm not sure it is really needed to help acceptance.
>> FWIW Cornelia already reviewed both patches.
>
> I'd keep the two patches separate, as each is easier to understand on
> its own IMO.
>
Ok, no problem.
Laurent
- Re: [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper, (continued)