[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2] ide: ahci: reset ncq object to
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2] ide: ahci: reset ncq object to unused on error |
|
Date: |
Mon, 11 Jan 2016 11:28:15 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 01/11/2016 10:00 AM, Kevin Wolf wrote:
> Am 08.01.2016 um 20:48 hat P J P geschrieben:
>> From: Prasad J Pandit <address@hidden>
>>
>> When processing NCQ commands, ACHI device emulation prepares a
>
> s/ACHI/AHCI/
>
> Can you still fix this in your tree, John?
>
> Kevin
>
Yes, thanks.
>> NCQ transfer object; To which an aio control block(aiocb) object
>> is assigned in 'execute_ncq_command'. In case, when the NCQ
>> command is invalid, the 'aiocb' object is not assigned, and NCQ
>> transfer object is left as 'used'. This leads to a use after
>> free kind of error in 'bdrv_aio_cancel_async' via 'ahci_reset_port'.
>> Reset NCQ transfer object to 'unused' to avoid it.
>>
>> Reported-by: Qinghao Tang <address@hidden>
>> Signed-off-by: Prasad J Pandit <address@hidden>
>