[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 05/11] cpu: Reclaim vCPU objects
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v6 05/11] cpu: Reclaim vCPU objects |
Date: |
Tue, 12 Jan 2016 15:13:13 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jan 08, 2016 at 12:25:13PM +0530, Bharata B Rao wrote:
> From: Gu Zheng <address@hidden>
>
> In order to deal well with the kvm vcpus (which can not be removed without any
> protection), we do not close KVM vcpu fd, just record and mark it as stopped
> into a list, so that we can reuse it for the appending cpu hot-add request if
> possible. It is also the approach that kvm guys suggested:
> https://www.mail-archive.com/address@hidden/msg102839.html
>
> Signed-off-by: Chen Fan <address@hidden>
> Signed-off-by: Gu Zheng <address@hidden>
> Signed-off-by: Zhu Guihua <address@hidden>
> Signed-off-by: Bharata B Rao <address@hidden>
> [- Explicit CPU_REMOVE() from qemu_kvm/tcg_destroy_vcpu()
> isn't needed as it is done from cpu_exec_exit()
> - Use iothread mutex instead of global mutex during
> destroy
> - Don't cleanup vCPU object from vCPU thread context
> but leave it to the callers (device_add/device_del)]
Reviewed-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v6 11/11] spapr: CPU hot unplug support, (continued)
- [Qemu-devel] [PATCH v6 07/11] xics, xics_kvm: Handle CPU unplug correctly, Bharata B Rao, 2016/01/08
- [Qemu-devel] [PATCH v6 08/11] target-ppc: Introduce PowerPC specific CPU core device, Bharata B Rao, 2016/01/08
- [Qemu-devel] [PATCH v6 03/11] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2016/01/08
- [Qemu-devel] [PATCH v6 05/11] cpu: Reclaim vCPU objects, Bharata B Rao, 2016/01/08
- [Qemu-devel] [PATCH v6 04/11] cpu: Don't realize CPU from cpu_generic_init(), Bharata B Rao, 2016/01/08
- [Qemu-devel] [PATCH v6 02/11] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/01/08
- [Qemu-devel] [PATCH v6 01/11] machine: Don't allow CPU toplogies with partially filled cores, Bharata B Rao, 2016/01/08