Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

[Paolo Bonzini]

On 12/01/2016 01:36, John Snow wrote:
> Instead of relying on peeking at bs->job, we want to explicitly get
> a reference to the job that was involved in this notifier callback.
> 
> Extend the Notifier to include a job pointer, and include a reference
> to the job registering the callback. This cuts out a few more cases
> where we have to rely on bs->job.
> 
> Signed-off-by: John Snow <address@hidden>

Why don't you just put the NotifierWithReturn inside the BackupBlockJob
struct, and use container_of to get from NWR to BackupBlockJob?

Paolo