Re: [Qemu-devel] [PATCH v3 0/2] change type of pci_bridge_initfn()

[Cao jin]

Did a hack to test dec realization:

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 319497e..134ab94 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -54,6 +54,7 @@
 #endif
 #include "migration/migration.h"
 #include "kvm_i386.h"
+#include "hw/pci-bridge/dec.h" //hack

 #define MAX_IDE_BUS 2

@@ -85,6 +86,7 @@ static void pc_init1(MachineState *machine,
     MemoryRegion *system_io = get_system_io();
     int i;
     PCIBus *pci_bus;
+    PCIBus *sec_bus; //hack
     ISABus *isa_bus;
     PCII440FXState *i440fx_state;
     int piix3_devfn = -1;
@@ -206,6 +208,9 @@ static void pc_init1(MachineState *machine,
     }
     isa_bus_irqs(isa_bus, gsi);

+    sec_bus = pci_dec_21154_init(pci_bus, -1);//hack
+    sec_bus = sec_bus; //suppress warning
+
     if (kvm_pic_in_kernel()) {
         i8259 = kvm_i8259_init(isa_bus);
     } else if (xen_enabled()) {

Then add "CONFIG_DEC_PCI=y" in x86_64-softmmu/config-devices.mak

Then, Can see dec bridge as attachment shows

On 01/14/2016 08:23 PM, Cao jin wrote:
> v3 changelog:
> 1. Just tweaked the commit message.
>
> Test:
> 1. Compiled.
> 2. Did a hack to test dec bridge realization, prove it is ok after patch.
>     Will reply this mail to attach the screenshot.
>
> Cao jin (2):
>    dec: convert to realize()
>    change type of pci_bridge_initfn() to void
>
>   hw/pci-bridge/dec.c                | 6 +++---
>   hw/pci-bridge/i82801b11.c          | 5 +----
>   hw/pci-bridge/ioh3420.c            | 6 +-----
>   hw/pci-bridge/pci_bridge_dev.c     | 8 +++-----
>   hw/pci-bridge/xio3130_downstream.c | 6 +-----
>   hw/pci-bridge/xio3130_upstream.c   | 6 +-----
>   hw/pci-host/apb.c                  | 5 +----
>   hw/pci/pci_bridge.c                | 3 +--
>   include/hw/pci/pci_bridge.h        | 2 +-
>   9 files changed, 13 insertions(+), 34 deletions(-)

--
Yours Sincerely,

Cao jin

dec_realize_test.jpg
Description: JPEG image