Re: [Qemu-devel] [RFC] target-i386: Display i386 CPUID properties

[Valentin Rakush]

On Tue, Jan 12, 2016 at 5:50 PM, Daniel P. Berrange <address@hidden> wrote:

On Tue, Jan 12, 2016 at 05:36:27PM +0300, Valentin Rakush wrote:
> This is RFC because implementation depends on the upcoming class
> properties
> http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg03115.html
> and also because this patch does not handle all x86_64 properties.
>
> This RFC is in response to concerns pointed in this review but with changed
> subject line as recommended.
> http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg00053.html
>
> This RFC demonstrates the way for displaying cpu properties using -cpu
> help option.

The point of doing this with QOM class properties, is such that we can
create a facility to query class properties for any QOM type in a
consistent manner.  I was expecting this would take the form of a
QMP monitor command 'qom-type-properties' or something along those
lines.

Hi Daniel,

thank you for comments. I will add and implement the following qmp command.

This is approximate sketch.

##

# @qom-type-list:

#

# This command will list any properties of a object class

# given a path in the object model.

#

# @path: the path within the object model.  See @qom-get for a description of

#        this parameter.

#

# Returns: a list of @ObjectPropertyInfo that describe the properties of the

#          object.

#

# Since: 2.6

##

{ 'command': 'qom-type-list',

  'data': { 'path': 'str' },

  'returns': [ 'ObjectPropertyInfo' ] }                               |                                                                                                                                        

Existing ObjectPropertyInfoList type will be reused for the returning value. I am not 

going to create new ObjectClassPropertyInfoList type.

There are not much specs on the topic, so please let me know if something different 

is expected.

--

Regards,
Valentin