[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union intros
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example |
Date: |
Thu, 14 Jan 2016 09:39:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/14/2016 08:13 AM, Markus Armbruster wrote:
> The implicit tag member is named "type", not "kind". Screwed up in
> commit 39a1815.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/qapi-code-gen.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
However, there's other errors in the documentation (we haven't kept it
up-to-date with recent churn in the generator), so maybe it's better to
fix all of them at once. See my Subset E series:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html
https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html
(I'll probably have to send a v9 of the series, but wanted to see if you
had any comments on v8 first)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature