[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/5] Add Error **errp for xen_pt_setup_vga()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/5] Add Error **errp for xen_pt_setup_vga() |
Date: |
Thu, 14 Jan 2016 15:31:00 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/13/2016 05:51 AM, Cao jin wrote:
> To catch the error msg. Also modify the caller
>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/xen/xen_pt.c | 7 +++++--
> hw/xen/xen_pt.h | 3 ++-
> hw/xen/xen_pt_graphics.c | 11 ++++++-----
> 3 files changed, 13 insertions(+), 8 deletions(-)
>
> +++ b/hw/xen/xen_pt_graphics.c
> @@ -172,13 +173,14 @@ int xen_pt_setup_vga(XenPCIPassthroughState *s,
> XenHostPCIDevice *dev)
> struct pci_data *pd = NULL;
>
> if (!is_igd_vga_passthrough(dev)) {
> - return -1;
> + error_setg(errp, "Need to enable igd-passthrough");
> + return;
> }
>
> bios = get_vgabios(s, &bios_size, dev);
> if (!bios) {
> - XEN_PT_ERR(&s->dev, "VGA: Can't getting VBIOS!\n");
> - return -1;
> + error_setg(errp, "VGA: Can't getting VBIOS");
As long as you are touching this, fix the grammar:
"VGA: Can't get VBIOS"
With that tweak,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 3/5] Add Error **errp for xen_pt_setup_vga(), Cao jin, 2016/01/13
- Re: [Qemu-devel] [PATCH v5 3/5] Add Error **errp for xen_pt_setup_vga(),
Eric Blake <=
[Qemu-devel] [PATCH v5 5/5] Xen PCI passthru: convert to realize(), Cao jin, 2016/01/13
[Qemu-devel] [PATCH v5 4/5] Add Error **errp for xen_pt_config_init(), Cao jin, 2016/01/13
Re: [Qemu-devel] [PATCH v5 0/5] Xen PCI passthru: Convert to realize(), Stefano Stabellini, 2016/01/14