Re: [Qemu-devel] [PATCH 2/2] xen-hvm: Clean up xen_ram_alloc() error handling

[Stefano Stabellini]

On Fri, 15 Jan 2016, Markus Armbruster wrote:
> Stefano Stabellini <address@hidden> writes:
> 
> > On Thu, 14 Jan 2016, Markus Armbruster wrote:
> >> xen_ram_alloc() dies with hw_error() on error, even though its caller
> >> ram_block_add() handles errors just fine.  Add an Error **errp
> >> parameter and use it.
> >> 
> >> Leave case RUN_STATE_INMIGRATE alone, because that looks like some
> >> kind of warning.
> 
> Did you double-check this is okay?

Yes, that's right: it is more of a debug message than a warning. Memory
is migrated by Xen, rather than by QEMU, so RUN_STATE_INMIGRATE we avoid
allocating any ram.


> >> Signed-off-by: Markus Armbruster <address@hidden>
> >
> > Reviewed-by: Stefano Stabellini <address@hidden>
> >
> > I am happy to queue both patches up in my next branch.
> 
> Please do, thanks!
>