Re: [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16

[Peter Maydell]

On 13 January 2016 at 16:03, Aurelien Jarno <address@hidden> wrote:
> The roundAndPackFloat16 function should return a float16 value, not a
> float32 one. Fix that.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  fpu/softfloat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Peter, given you are working on softfloat patches, you might want to get
> this one merged at the same time.
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index f1170fe..acc9099 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -3368,7 +3368,7 @@ static float16 packFloat16(flag zSign, int_fast16_t 
> zExp, uint16_t zSig)
>  | Binary Floating-Point Arithmetic.
>  
> *----------------------------------------------------------------------------*/
>
> -static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
> +static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
>                                     uint32_t zSig, flag ieee,
>                                     float_status *status)
>  {

Reviewed-by: Peter Maydell <address@hidden>

(a harmless error in the current code but we might as well get it right).

thanks
-- PMM