[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/15] scsi: initialise info object with appropriate
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 04/15] scsi: initialise info object with appropriate size |
Date: |
Fri, 15 Jan 2016 17:04:20 +0100 |
From: P J P <address@hidden>
While processing controller 'CTRL_GET_INFO' command, the routine
'megasas_ctrl_get_info' overflows the '&info' object size. Use its
appropriate size to null initialise it.
Reported-by: Qinghao Tang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Message-Id: <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/megasas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index d7dc667..576f56c 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -718,7 +718,7 @@ static int megasas_ctrl_get_info(MegasasState *s,
MegasasCmd *cmd)
BusChild *kid;
int num_pd_disks = 0;
- memset(&info, 0x0, cmd->iov_size);
+ memset(&info, 0x0, dcmd_size);
if (cmd->iov_size < dcmd_size) {
trace_megasas_dcmd_invalid_xfer_len(cmd->index, cmd->iov_size,
dcmd_size);
--
1.8.3.1
- [Qemu-devel] [PULL 00/15] NBD, chardev, SCSI patches for 2015-01-15, Paolo Bonzini, 2016/01/15
- [Qemu-devel] [PULL 02/15] target-i386: do not duplicate page protection checks, Paolo Bonzini, 2016/01/15
- [Qemu-devel] [PULL 01/15] scsi: revert change to scsi_req_cancel_async and add assertions, Paolo Bonzini, 2016/01/15
- [Qemu-devel] [PULL 04/15] scsi: initialise info object with appropriate size,
Paolo Bonzini <=
- [Qemu-devel] [PULL] i386: avoid null pointer dereference, Paolo Bonzini, 2016/01/15
- [Qemu-devel] [PULL 05/15] vmw_pvscsi: x-disable-pcie, x-old-pci-configuration back-compat props are 2.5 specific, Paolo Bonzini, 2016/01/15
- [Qemu-devel] [PULL 07/15] iscsi: send readcapacity10 when readcapacity16 failed, Paolo Bonzini, 2016/01/15
- [Qemu-devel] [PULL 03/15] i386: avoid null pointer dereference, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 12/15] nbd-server: do not check request length except for reads and writes, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 06/15] qemu-char: delete send_all/recv_all helper methods, Paolo Bonzini, 2016/01/15