|
From: | Marcel Apfelbaum |
Subject: | Re: [Qemu-devel] [PATCH v16 04/14] vfio: make the 4 bytes aligned for capability size |
Date: | Sun, 17 Jan 2016 14:30:56 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 01/12/2016 04:43 AM, Cao jin wrote:
From: Chen Fan <address@hidden> this function search the capability from the end, the last size should 0x100 - pos, not 0xff - pos.
Indeed, "next" should be the first address of the next capability. Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Chen Fan <address@hidden> --- hw/vfio/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index a63cf85..288f2c7 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1469,7 +1469,8 @@ static void vfio_unmap_bars(VFIOPCIDevice *vdev) */ static uint8_t vfio_std_cap_max_size(PCIDevice *pdev, uint8_t pos) { - uint8_t tmp, next = 0xff; + uint8_t tmp; + uint16_t next = PCI_CONFIG_SPACE_SIZE; for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp; tmp = pdev->config[tmp + 1]) {
[Prev in Thread] | Current Thread | [Next in Thread] |