|
From: | Alexey Kardashevskiy |
Subject: | Re: [Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld |
Date: | Mon, 18 Jan 2016 10:51:51 +1100 |
User-agent: | Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/16/2016 12:14 PM, David Gibson wrote:
The rtas_ld() and rtas_st() helpers were designed for loading RTAS arguments and storing RTAS returns which are in a simple, common array format. However, a number of RTAS routines - and even non-RTAS routines - have started using these for accessing other memory buffers, where the normal qemu memory access routines would be more appropriate. This series removes some of these abuses of the RTAS accessors.
imho simple renaming rtas_st to stl_be_phys_real (and so on for other rtas_xx) would make more sense as rtas_st&co do not have to do anything with RTAS itself, it is all about realmode guest memory accessб RTAS just happened to be the first client of it.
btw in st_cc_buf(), what does "cc" stand for? -- Alexey
[Prev in Thread] | Current Thread | [Next in Thread] |