[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of FindSysb
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of FindSysbusDeviceFunc |
Date: |
Tue, 19 Jan 2016 11:37:12 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jan 18, 2016 at 06:45:14PM +0100, Andreas Färber wrote:
> Am 18.01.2016 um 05:39 schrieb David Gibson:
> > Functions of type FindSysbusDeviceFunc currently return an integer. I
> > recently made an error in a patch because I assumed that this return value
> > would control whether iteration of the function across devices continues
> > or not. In fact, the function's return value is always ignored.
> >
> > This changes the function type to return void, so that others don't make
> > the same mistake.
>
> Have you considered implementing the behavior you expected? :)
> Not necessary for your use case or too complicated?
A bit of both.
> > Signed-off-by: David Gibson <address@hidden>
> > ---
> >
> > Please apply.
>
> Patch looks okay, too short notice for today's pull though.
> Usually we avoid "I" in a commit message.
True, that probably won't make so much sense sitting in the commit
history. I'll reword and resend.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature