Re: [Qemu-devel] [PATCH] .travis.yml: migrate to container builds

[David Gibson]

On Tue, Jan 19, 2016 at 07:22:07AM +0000, Alex Bennée wrote:
> 
> David Gibson <address@hidden> writes:
> 
> > On Fri, Jan 15, 2016 at 10:45:09AM +0000, Alex Bennée wrote:
> >> This moves the Travis tests from their old legacy VM
> >> infrastructure (which only seems to run 5-6 jobs at once) to their new
> >> container based approach.
> >>
> >> The principle difference is there is no sudo in the containers so all
> >> packages are installed using the apt add-on. This means one of the build
> >> combinations can be dropped as it was only for checking the build with
> >> additional packages.
> >>
> >> I've disabled the user-space tracing build until the dependant packages
> >> go through the Travis package white-listing process.
> >>
> >> Signed-off-by: Alex Bennée <address@hidden>
> >
> > Tested-by: David Gibson <address@hidden>
> >
> > Is it safe to just drop that build combination, or should we instead
> > be doing something else to test the build _without_ those extra
> > packages?
> 
> Hmm, currently there doesn't seem to be a way to do this with the Travis
> infrastructure as the packages are no longer part of a matrix.

Ok, but would it work to explicitly disable use of the packages in
some of the builds?

> > [snip]
> >> @@ -86,10 +103,10 @@ matrix:
> >>      - env: TARGETS=i386-softmmu,x86_64-softmmu
> >>             EXTRA_CONFIG="--enable-trace-backends=ftrace"
> >>        compiler: gcc
> >> -    - env: TARGETS=i386-softmmu,x86_64-softmmu
> >> -          EXTRA_PKGS="liblttng-ust-dev liburcu-dev"
> >> -          EXTRA_CONFIG="--enable-trace-backends=ust"
> >> -      compiler: gcc
> >> +    # UST backend disabled until liblttng-ust-dev pkg white-listed
> >> +    #- env: TARGETS=i386-softmmu,x86_64-softmmu
> >> +    #       EXTRA_CONFIG="--enable-trace-backends=ust"
> >> +    #  compiler: gcc
> >
> > This comment is a bit confusing to me, since the apt addon package
> > list already seems to include liblttng-ust-dev.
> 
> It's in the list but still awaiting whitelisting by Travis:
> 
> https://github.com/travis-ci/apt-package-whitelist/issues/2258

Ah, ok.  I'm kind of surprised that Travis passes a build requesting a
non-whitelisted package.

Do we want to wait until that's approved before merging?  I don't have
a strong opinion either way.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature