[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for thrott
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options |
Date: |
Wed, 20 Jan 2016 15:39:22 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 01/20 08:25, Markus Armbruster wrote:
> Fam Zheng <address@hidden> writes:
>
> > v5: Add valid value testing in iotests. [Berto]
> > Add details in commit message. [Markus]
> > Use "%lld" in format string. [Markus]
> > Fix ")" -> "]" in error message. [Kevin]
> >
> > Now the negative values are silently converted to a huge positive number
> > because we are doing implicit casting from uint64_t to double. Fix it and
> > add a
> > test case (this was once fixed in 7d81c1413c9 but regressed when the block
> > device option parsing code was changed).
>
> Series
> Reviewed-by: Markus Armbruster <address@hidden>
Thanks!
Fam
- [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options, Fam Zheng, 2016/01/19
- [Qemu-devel] [PATCH v5 1/2] blockdev: Error out on negative throttling option values, Fam Zheng, 2016/01/19
- [Qemu-devel] [PATCH v5 2/2] iotests: Test that throttle values ranges, Fam Zheng, 2016/01/19
- Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options, Markus Armbruster, 2016/01/20
- Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options, Alberto Garcia, 2016/01/20
- Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options, Kevin Wolf, 2016/01/20