[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v4 0/3] Use QCryptoSecret for block device passwords

From: Daniel P. Berrange
Subject: [Qemu-devel] [PATCH v4 0/3] Use QCryptoSecret for block device passwords
Date: Thu, 21 Jan 2016 14:19:18 +0000

This series was previously posted:

  v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html
  v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03809.html
  v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03461.html

The RBD, Curl and iSCSI block device drivers all need the ability
to accept a password to authenticate with the remote network storage
server. Currently RBD and iSCSI both just take the password in clear
text as part of the block parameters which is insecure (passwords are
visible in the process listing), while Curl doesn't support auth at

This series updates all three drivers so that they use the recently
merged QCryptoSecret API for getting passwords. Each driver gains
a 'passwordid' property that can be set to provide the ID of a
QCryptoSecret object instance, which in turn provides the actual
password data.

This series is required in order to fix a long standing CVE security
flaw in libvirt, whereby passwords are exposed in the command line
arguments and so visible in process listing

This series would benefit from the --object additions to qemu-img,
qemu-io and qemu-nbd, but this is not a pre-requisite for its merge
as it us still useful in the system emulator without that support:


Changed in v4:

 - Rename 'password-id' to 'password-secret', 'proxy-password-id'
   to 'proxy-password-secret' (Paolo)

Changed in v3:

 - Rename 'passwordid' to 'password-id', 'proxypasswordid'
   to 'proxy-password-id' and 'proxyusername' to 'proxy-username'

Daniel P. Berrange (3):
  rbd: add support for getting password from QCryptoSecret object
  curl: add support for HTTP authentication parameters
  iscsi: add support for getting CHAP password via QCryptoSecret API

 block/curl.c  | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 block/iscsi.c | 24 +++++++++++++++++++++-
 block/rbd.c   | 47 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 136 insertions(+), 1 deletion(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]