[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter wh
From: |
Wen Congyang |
Subject: |
Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets |
Date: |
Fri, 22 Jan 2016 17:32:45 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/22/2016 04:36 PM, zhanghailiang wrote:
> If the filter is disabled, don't go through it.
>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
> include/net/filter.h | 5 +++++
> net/net.c | 4 ++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/net/filter.h b/include/net/filter.h
> index 9ed5ec6..d797ee4 100644
> --- a/include/net/filter.h
> +++ b/include/net/filter.h
> @@ -74,6 +74,11 @@ ssize_t qemu_netfilter_pass_to_next(NetClientState *sender,
> int iovcnt,
> void *opaque);
>
> +static inline bool qemu_need_skip_netfilter(NetFilterState *nf)
> +{
> + return nf->enabled ? false : true;
> +}
> +
> void netfilter_print_info(NetFilterState *nf, char *output_str, int size);
>
> #endif /* QEMU_NET_FILTER_H */
> diff --git a/net/net.c b/net/net.c
> index 87de7c0..ec43105 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -581,6 +581,10 @@ static ssize_t filter_receive_iov(NetClientState *nc,
> NetFilterState *nf = NULL;
>
> QTAILQ_FOREACH(nf, &nc->filters, next) {
> + /* Don't go through filter if it is off */
> + if (qemu_need_skip_netfilter(nf)) {
> + continue;
> + }
> ret = qemu_netfilter_receive(nf, direction, sender, flags, iov,
> iovcnt, sent_cb);
> if (ret) {
>
qemu_netfilter_pass_to_next() shoule also be updated.
Thanks
Wen Congyang
- Re: [Qemu-devel] [PATCH RFC 2/7] net/filter: Add a 'status' property for filter object, (continued)
[Qemu-devel] [PATCH RFC 4/7] net/filter: Introduce a helper to add a filter to the netdev, zhanghailiang, 2016/01/22
[Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets, zhanghailiang, 2016/01/22
- Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets,
Wen Congyang <=
[Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval, zhanghailiang, 2016/01/22
[Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev, zhanghailiang, 2016/01/22