[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/28] target-ppc: gdbstub: fix altivec registers for
From: |
David Gibson |
Subject: |
[Qemu-devel] [PULL 23/28] target-ppc: gdbstub: fix altivec registers for little-endian guests |
Date: |
Mon, 25 Jan 2016 12:15:22 +1100 |
From: Greg Kurz <address@hidden>
Altivec registers are 128-bit wide. They are stored in memory as two
64-bit values that must be byteswapped when the guest is little-endian.
Let's reuse the ppc_maybe_bswap_register() helper for this.
We also need to fix the ordering of the 64-bit elements according to
the target endianness, for both system and user mode.
Signed-off-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
target-ppc/translate_init.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 54720ca..4c29912 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8754,9 +8754,9 @@ static void dump_ppc_insns (CPUPPCState *env)
static bool avr_need_swap(CPUPPCState *env)
{
#ifdef HOST_WORDS_BIGENDIAN
- return false;
+ return msr_le;
#else
- return true;
+ return !msr_le;
#endif
}
@@ -8800,14 +8800,18 @@ static int gdb_get_avr_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
stq_p(mem_buf, env->avr[n].u64[1]);
stq_p(mem_buf+8, env->avr[n].u64[0]);
}
+ ppc_maybe_bswap_register(env, mem_buf, 8);
+ ppc_maybe_bswap_register(env, mem_buf + 8, 8);
return 16;
}
if (n == 32) {
stl_p(mem_buf, env->vscr);
+ ppc_maybe_bswap_register(env, mem_buf, 4);
return 4;
}
if (n == 33) {
stl_p(mem_buf, (uint32_t)env->spr[SPR_VRSAVE]);
+ ppc_maybe_bswap_register(env, mem_buf, 4);
return 4;
}
return 0;
@@ -8816,6 +8820,8 @@ static int gdb_get_avr_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
static int gdb_set_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n)
{
if (n < 32) {
+ ppc_maybe_bswap_register(env, mem_buf, 8);
+ ppc_maybe_bswap_register(env, mem_buf + 8, 8);
if (!avr_need_swap(env)) {
env->avr[n].u64[0] = ldq_p(mem_buf);
env->avr[n].u64[1] = ldq_p(mem_buf+8);
@@ -8826,10 +8832,12 @@ static int gdb_set_avr_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
return 16;
}
if (n == 32) {
+ ppc_maybe_bswap_register(env, mem_buf, 4);
env->vscr = ldl_p(mem_buf);
return 4;
}
if (n == 33) {
+ ppc_maybe_bswap_register(env, mem_buf, 4);
env->spr[SPR_VRSAVE] = (target_ulong)ldl_p(mem_buf);
return 4;
}
--
2.5.0
- [Qemu-devel] [PULL 15/28] pseries: Clean up error handling in spapr_rtas_register(), (continued)
- [Qemu-devel] [PULL 15/28] pseries: Clean up error handling in spapr_rtas_register(), David Gibson, 2016/01/24
- [Qemu-devel] [PULL 14/28] pseries: Clean up error handling in spapr_vga_init(), David Gibson, 2016/01/24
- [Qemu-devel] [PULL 21/28] target-ppc: gdbstub: fix float registers for little-endian guests, David Gibson, 2016/01/24
- [Qemu-devel] [PULL 16/28] pseries: Clean up error handling in xics_system_init(), David Gibson, 2016/01/24
- [Qemu-devel] [PULL 27/28] cuda.c: return error for unknown commands, David Gibson, 2016/01/24
- [Qemu-devel] [PULL 28/28] uninorth.c: add support for UniNorth kMacRISCPCIAddressSelect (0x48) register, David Gibson, 2016/01/24
- [Qemu-devel] [PULL 25/28] target-ppc: gdbstub: Add VSX support, David Gibson, 2016/01/24
- [Qemu-devel] [PULL 17/28] pseries: Clean up error reporting in ppc_spapr_init(), David Gibson, 2016/01/24
- [Qemu-devel] [PULL 24/28] target-ppc: gdbstub: fix spe registers for little-endian guests, David Gibson, 2016/01/24
- [Qemu-devel] [PULL 22/28] target-ppc: gdbstub: introduce avr_need_swap(), David Gibson, 2016/01/24
- [Qemu-devel] [PULL 23/28] target-ppc: gdbstub: fix altivec registers for little-endian guests,
David Gibson <=
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Peter Maydell, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Peter Maydell, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Peter Maydell, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/26
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Alexander Graf, 2016/01/26
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Gerd Hoffmann, 2016/01/26
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/27
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Gerd Hoffmann, 2016/01/27