Re: [Qemu-devel] [PATCH v3 0/4] blockdev: Fix 'change' for slot devices

[Kevin Wolf]

Am 22.01.2016 um 23:50 hat Max Reitz geschrieben:
> The series "BlockBackend and media" intended all block devices with
> removable media to implement a tray model; if the devices does not have
> a tray, it should emulate one.
> 
> While this may make sense from a technical perspective (blockdev-*-tray
> are guest device controlling operations, invoking
> blk_dev_change_media_cb(); blockdev-*-medium are operations concerning
> the block layer, controlling the BB-BDS link), it is (probably)
> unintuitive to users, and it requires said implementation of an emulated
> tray for each of the slot devices (floppy disk drives and SD card
> readers).
> 
> We can get rid of those virtual trays by special-casing tray-less
> devices in blockdev-*-tray (those operations are no-ops there) and in
> blockdev-*-medium (those operations then have to invoke
> blk_dev_change_media_cb()). With this change, changing the medium
> inserted into a slot device will no longer emit TRAY_MOVED events (which
> seems like a bugfix to me, because slot devices actually do not have
> trays).

Thanks, applied to the block branch.

Kevin