Re: [Qemu-devel] [PATCH 00/13] cuda: misc fixes and cleanups

[Mark Cave-Ayland]

On 25/01/16 09:58, Alyssa Milburn wrote:

> On Sat, Jan 23, 2016 at 09:39:57PM +0100, Hervé Poussineau wrote:
>> Hi,
>>
>> This patchset cleans up a little bit the Apple CUDA emulation:
>> - correctly reject unknown commands
>> - correctly reject commands with wrong parameters
>> - support changing the frequency of auto-polling
>> - support changing device list probed in auto-poll
>> - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
>> - remove unused commands (GET/SET_6805_ADDR)
>> - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC
>>
>> GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once
>> we implement the I2C bus provided by CUDA.
> 
> Neat! (I wish I'd seen this before trying to debug issues with this code!)
> Do you have any plans to work on this code further? The VIA register code
> doesn't seem to really match what the hardware does, and I've been wondering
> if it's responsible for weird input problems under Mac OS, but didn't find
> time to look into it yet (and don't want to duplicate effort).

David had some review comments (and I still need to have a look in
detail) so as long as it passes my various OpenBIOS OS tests then there
is a good chance it can be applied during this release cycle.


ATB,

Mark.