[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/8] iotests: Move _filter_nbd into common.filter
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 4/8] iotests: Move _filter_nbd into common.filter |
Date: |
Mon, 25 Jan 2016 19:41:11 +0100 |
_filter_nbd can be useful for other NBD tests, too, therefore it should
reside in common.filter.
Signed-off-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/083 | 12 ------------
tests/qemu-iotests/common.filter | 12 ++++++++++++
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/qemu-iotests/083 b/tests/qemu-iotests/083
index 36e6de8..aa99278 100755
--- a/tests/qemu-iotests/083
+++ b/tests/qemu-iotests/083
@@ -49,18 +49,6 @@ wait_for_tcp_port() {
done
}
-_filter_nbd()
-{
- # nbd.c error messages contain function names and line numbers that are
- # prone to change. Message ordering depends on timing between send and
- # receive callbacks sometimes, making them unreliable.
- #
- # Filter out the TCP port number since this changes between runs.
- sed -e 's#^.*nbd/.*\.c:.*##g' \
- -e 's#nbd:127\.0\.0\.1:[^:]*:#nbd:127\.0\.0\.1:PORT:#g' \
- -e 's#\(exportname=foo\|PORT\): Failed to .*$#\1#'
-}
-
check_disconnect() {
event=$1
when=$2
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index cfdb633..33ed1e4 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
@@ -230,5 +230,17 @@ _filter_qemu_img_map()
-e 's/Mapped to *//' | _filter_testdir | _filter_imgfmt
}
+_filter_nbd()
+{
+ # nbd.c error messages contain function names and line numbers that are
+ # prone to change. Message ordering depends on timing between send and
+ # receive callbacks sometimes, making them unreliable.
+ #
+ # Filter out the TCP port number since this changes between runs.
+ sed -e 's#^.*nbd/.*\.c:.*##g' \
+ -e 's#nbd:127\.0\.0\.1:[^:]*:#nbd:127\.0\.0\.1:PORT:#g' \
+ -e 's#\(exportname=foo\|PORT\): Failed to .*$#\1#'
+}
+
# make sure this script returns success
true
--
2.7.0
- [Qemu-devel] [PATCH 0/8] nbd: Fix failed assertion on negotiation error, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 2/8] iotests: Rename filter_nbd to _filter_nbd in 083, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 3/8] iotests: Change coding style of _filter_nbd in 083, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 4/8] iotests: Move _filter_nbd into common.filter,
Max Reitz <=
- [Qemu-devel] [PATCH 6/8] iotests: Make _filter_nbd support more URL types, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 5/8] iotests: Make _filter_nbd drop log lines, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 7/8] iotests: Make redirecting qemu's stderr optional, Max Reitz, 2016/01/25
- [Qemu-devel] [PATCH 8/8] iotests: Add test for a nonexistent NBD export, Max Reitz, 2016/01/25
- Re: [Qemu-devel] [PATCH 0/8] nbd: Fix failed assertion on negotiation error, Kevin Wolf, 2016/01/26