Re: [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer

[Zhang Chen]

On 01/28/2016 12:10 AM, Eric Blake wrote:
> On 01/26/2016 05:44 PM, Hailiang Zhang wrote:
> > On 2016/1/26 16:59, Zhang Chen wrote:
> > > From: ZhangChen <address@hidden>
> > >
> > > Traffic-mirrorer is a plugin of netfilter.
> > > It make qemu has ability to copy and mirror guest's
> > > net packet. we output packet to chardev.
> > >
> > > +static void traffic_mirrorer_setup(NetFilterState *nf, Error **errp)
> > > +{
> > > +    MirrorerState *s = FILTER_TRAFFIC_MIRRORER(nf);
> > > +
> > > +    if (!s->outdev) {
> > > +        error_setg(errp, "filter traffic mirrorer needs 'outdev'
> > > property set!"
> > > +                "property set!");
> > Duplicate 'property set!'.
> For that matter, error_setg() messages should never end in '!'.

Thanks, I will fix it in V3
zhangchen


--
Thanks
zhangchen