Re: [Qemu-devel] [PATCH v1 2/5] configure: ensure ldflags propagated to config_host

[Paolo Bonzini]

On 28/01/2016 11:15, Alex Bennée wrote:
> diff --git a/configure b/configure
> index bd29ba7..148b79a 100755
> --- a/configure
> +++ b/configure
> @@ -5871,7 +5871,7 @@ if test "$target_linux_user" = "yes" -o 
> "$target_bsd_user" = "yes" ; then
>    ldflags="$ldflags $textseg_ldflags"
>  fi
>  
> -echo "LDFLAGS+=$ldflags" >> $config_target_mak
> +echo "LDFLAGS+=$ldflags" >> $config_host_mak
>  echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>  
>  done # for target in $targets

Hmm wait, it's not okay.

This adds the *target* LDFLAGS to config-host.mak, and adds them a
zillion times.  extra-ldflags is already added to LDFLAGS in
config-host.mak:

  --extra-ldflags=*) LDFLAGS="$LDFLAGS $optarg"
                     EXTRA_LDFLAGS="$optarg"
  ;;

...

echo "LDFLAGS=$LDFLAGS" >> $config_host_mak

So I'm totally confused as to what this patch is trying to achieve...

Paolo