[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Move qemu-binfmt-conf.sh to Debian
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Move qemu-binfmt-conf.sh to Debian model |
Date: |
Thu, 28 Jan 2016 19:45:56 +0000 |
On 28 January 2016 at 19:40, Laurent Vivier <address@hidden> wrote:
>
>
> Le 28/01/2016 20:36, Peter Maydell a écrit :
>> On 28 January 2016 at 19:35, Alexander Graf <address@hidden> wrote:
>>>> Am 28.01.2016 um 21:27 schrieb Laurent Vivier <address@hidden>:
>>>> Peter, if you agree to take the file as-is, I can resend the last
>>>> version. :)
>>>
>>> The script can generate data files just fine, no? So if a distro
>>> only wants those, they can call the script at packaging time.
>>
>> I prefer data files because I think they're easier to maintain
>> from the QEMU source point of view (for instance adding a new
>> target is just adding a file for the target, rather than having to
>> edit a script).
>
> I understand your point of view: the difficulty is to allow the script
> to find the data files: I like to use the script directly from the
> qemu/scripts directory and to not install it (so no path configured in
> the scripts).
"Find the directory the script is in" is easy:
THISDIR="$(cd "$(dirname "$0")"; pwd)"
We don't ever install that script anywhere, so we don't need to
worry about the "script has been installed" case.
thanks
-- PMM