[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ide: ahci: add check before calling dma_memo

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] ide: ahci: add check before calling dma_memory_unmap
Date: Thu, 28 Jan 2016 21:41:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 28/01/2016 20:57, John Snow wrote:
> This is fine for now as it protects us against doing something stupid in
> a mechanical fashion, but I still wonder under which case we are
> "starting" the FIS or CLB engines without getting a valid address. (The
> unmap should only be happening when we /stop/ the engines, which implies
> they were started -- which points to a bug somewhere else, too.)

It can happen if both of them are registered to an MMIO address.  The
second map will fail.

Perhaps it's a better fix to switch FIS and CLB to
address_space_read/write, but this works as a simple fix for the SEGV.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]