qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PULL 03/39] macio: use the existing IDEDMA


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 03/39] macio: use the existing IDEDMA aiocb to hold the active DMA aiocb
Date: Fri, 29 Jan 2016 09:02:47 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

On 2016-01-29 16:06, David Gibson wrote:
> From: Mark Cave-Ayland <address@hidden>
> 
> Currently the aiocb is held within MACIOIDEState, however the IDE core code
> assumes that the current actvie DMA aiocb is held in aiocb in a few places,
> e.g. ide_bus_reset() and ide_reset().
> 
> Switch over to using IDEDMA aiocb to store the aiocb for the current active
> DMA request so that bus resets and restarts are handled correctly. As a
> consequence we can now use ide_set_inactive() rather than handling its
> functionality ourselves.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> Signed-off-by: David Gibson <address@hidden>
> ---
>  hw/ide/macio.c      |  20 +-
>  hw/ide/macio.c.orig | 634 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++

I don't think you want to add this file to the git.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]